Skip to content

Upload: Uploading multiple submissions#390

Merged
Flickdm merged 2 commits into
microsoft:mainfrom
Flickdm:upload/new_submissions_4_8_2026
Apr 9, 2026
Merged

Upload: Uploading multiple submissions#390
Flickdm merged 2 commits into
microsoft:mainfrom
Flickdm:upload/new_submissions_4_8_2026

Conversation

@Flickdm
Copy link
Copy Markdown
Member

@Flickdm Flickdm commented Apr 8, 2026

Description

Uploading multiple submissions so I can clean up and correct a few things

submissions:
#384
#374

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

@Flickdm Flickdm force-pushed the upload/new_submissions_4_8_2026 branch 3 times, most recently from 796a03f to 4978ade Compare April 8, 2026 18:31
HagiwaraHW and others added 2 commits April 8, 2026 11:31
Ref: microsoft#374

These files were uploaded originally with the following ASN.1 structure,
which includes an outer `ContentInfo` SEQUENCE:

```
ContentInfo ::= SEQUENCE {
    contentType   id-signedData (1.2.840.113549.1.7.2),
    content [0]   SignedData { ... }
}
```

This is problematic because until recently, this was not supported by
EDK2 based firmware.

microsoft/mu_tiano_plus@37d3eb0

To achieve the most compatibility with existing firmware, the files have
been stripped of  the outer ContentInfo envelope and stores the
**SignedData** SEQUENCE directly as `CertData`, starting at
`30 82 05 82 02 01 01 ...` (version=1, ...).

The `dwLength` field in `WIN_CERTIFICATE` was also decremented by 19 to
|reflect the shorter `CertData`. Everything else
(the `EFI_TIME`, GUID, `SignedData` contents, and the variable payload)
is byte-identical.
@Flickdm Flickdm force-pushed the upload/new_submissions_4_8_2026 branch from 4978ade to 67dd6c4 Compare April 8, 2026 18:31
@Flickdm Flickdm marked this pull request as ready for review April 8, 2026 18:32
@Flickdm Flickdm requested a review from Javagedes April 8, 2026 19:58
@Flickdm Flickdm merged commit f475aff into microsoft:main Apr 9, 2026
5 checks passed
@Flickdm Flickdm deleted the upload/new_submissions_4_8_2026 branch April 9, 2026 15:05
@hughsie
Copy link
Copy Markdown

hughsie commented Apr 9, 2026

Mirrored to the LVFS as https://fwupd.org/lvfs/firmware/132782/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants